#4848: Patches to verify-gip-for-cemon

#

Thu Feb 12 14:57:18 2009

parag@fnal.gov - Ticket created

Subject:	Patches to verify-gip-for-cemon
Date:	Thu, 12 Feb 2009 14:54:05 -0600
To:	vdt-support@OPENSCIENCEGRID.ORG
From:	Parag Mhashilkar <parag@fnal.gov>

Download (untitled) / with headers
text/plain 621b

Hi Alain/Scott,

I have attached new version of TestOSGGlueSchema.class. This includes some bug fixes and support for additional option --summary to the suppress the output to minimal in case there are no warnings or errors.

I do not know who came up with the verify-gip-for-cemon-wrapper script. I do not find it in ReSS CVS so at the moment assuming that VDT put it in place. Script distributed in VDT doesn't give any means to pass command line option to the Java class TestOSGGlueSchema. I have attached the patched version of the script that fixes this issue.

Please let me know if you have any questions.

-Parag

Download verify-gip-for-cemon-wrapper
application/octet-stream 368b

Download TestOSGGlueSchema.class
application/octet-stream 11.2k

#	Thu Feb 12 15:28:54 2009	roy - Taken

#	Thu Feb 12 15:31:12 2009	roy - Correspondence added		[Reply]
	Download (untitled) / with headers text/plain 1k > I have attached new version of TestOSGGlueSchema.class. This includes > some bug fixes and support for additional option --summary to the > suppress the output to minimal in case there are no warnings or > errors. In the past, Tanya has always supplied this to us as Java source. I would like to continue doing that. Is that okay? What is the new version number of this program? Can you be a bit more specific about the fixes? I don't know how to decide if this goes into our ITB testing, or needs to be pushed our more quickly. > I do not know who came up with the verify-gip-for-cemon-wrapper > script. I do not find it in ReSS CVS so at the moment assuming that > VDT put it in place. Script distributed in VDT doesn't give any > means to pass command line option to the Java class > TestOSGGlueSchema. I have attached the patched version of the > script that fixes this issue. I forget who came up with it, but it's checked into the VDT source code repository. We can update it at hte same time. -alain

#	Thu Feb 12 15:31:12 2009	RT_System - Status changed from 'new' to 'open'

#

Thu Feb 12 16:28:04 2009

parag@fnal.gov - Correspondence added

[Reply]

CC:	weigand@fnal.gov
Subject:	Re: [vdt-support #4848] Patches to verify-gip-for-cemon
Date:	Thu, 12 Feb 2009 16:27:20 -0600
To:	vdt-support@OPENSCIENCEGRID.ORG
From:	Parag Mhashilkar <parag@fnal.gov>

Download (untitled) / with headers
text/plain 2.4k

Hi Alain,

Adding John to the list, since he helped me identifying the bug and is also the prime requester of --summary feature. This way he will know when the changes will be available in ITB.

I have attached the java code as well. I have no problems with distributing the Java code just that I wasn't aware of the protocol you and Tanya agreed upon.

I should have been more clear about the cache, this fixes should go in ITB cache.

Version: 1.5

Release Notes:

Bugs Fixes:

- There was a bug in the way output from the process glite-ce-info was checked for. TestOSGGlueSchema now correctly waits for the glite-ce-info to finish before its output is tested.

Improvements:

- If the script glite-ce-info does not produce any output, TestOSGGlueSchema will exit with an appropriate error message.
- TestOSGGlueSchema supports --summary / -s option which only prints the summary instead of description of classads, i.e. the total number of classads that will be generated. However this option will not hide any potential warnings or error messages.

Let me know if you have any questions.

-Parag

----- Original Message -----
From: Alain Roy via RT <vdt-support@opensciencegrid.org>
Date: Thursday, February 12, 2009 3:31 pm
Subject: [vdt-support #4848] Patches to verify-gip-for-cemon
To: parag@fnal.gov

> > I have attached new version of TestOSGGlueSchema.class. This includes
> > some bug fixes and support for additional option --summary to the
> > suppress the output to minimal in case there are no warnings or
> > errors.

>
> In the past, Tanya has always supplied this to us as Java source. I
> would like to continue doing that. Is that okay?
>
> What is the new version number of this program? Can you be a bit more
> specific about the fixes? I don't know how to decide if this goes into
> our ITB testing, or needs to be pushed our more quickly.
>

> > I do not know who came up with the verify-gip-for-cemon-wrapper
> > script. I do not find it in ReSS CVS so at the moment assuming that
> > VDT put it in place. Script distributed in VDT doesn't give any
> > means to pass command line option to the Java class
> > TestOSGGlueSchema. I have attached the patched version of the
> > script that fixes this issue.

>
> I forget who came up with it, but it's checked into the VDT source code
> repository. We can update it at hte same time.
>
> -alain
>
>
>
> --
> View ticket at <
> VDT Support: vdt-support@opensciencegrid.org

Download TestOSGGlueSchema.java
text/x-java 18.3k

#

Thu Feb 12 18:30:57 2009

kronenfe - Comments added

[Reply]

Subject:	[vdt-support #4848] SVN commit, rev 8713
To:	vdt-support@cs.wisc.edu
From:	kronenfe@cs.wisc.edu

Download (untitled) / with headers
text/plain 359b

Commit comment:
Upgrading Verify-GIP-For-CEMon from 1.4 to 1.5
Added a small fix to the wrapper script (supplied by Parag)

Changed files:
U vdt/branches/vdt-1.10.1-gums-prima/Verify-GIP-For-CEMon/verify-gip-for-cemon/verify-gip-for-cemon-wrapper
U vdt/branches/vdt-1.10.1-gums-prima/defs

To generate a diff:
svn diff -c 8713 file:///p/vdt/workspace/svn

#	Thu Feb 12 18:36:07 2009	kronenfe - AdminCc kronenfe added

#

Mon Feb 16 15:11:48 2009

parag@fnal.gov - Correspondence added

[Reply]

Subject:	Re: [vdt-support #4848] Patches to verify-gip-for-cemon
Date:	Mon, 16 Feb 2009 15:11:14 -0600
To:	vdt-support@OPENSCIENCEGRID.ORG
From:	Parag Mhashilkar <parag@fnal.gov>

Download (untitled) / with headers
text/plain 1.7k

Scott,

Looks like I gave you wrong java file in my last email :(.

I have attached the correct one to the email now.

Also, I made another fix the shell script. It now returns with the
return code of the Java class rather than the rm command.

Can you please include these fixes in the new ITB release.

Thanks

On Thu, 2009-02-12 at 15:31 -0600, Alain Roy via RT wrote:

> > I have attached new version of TestOSGGlueSchema.class. This includes
> > some bug fixes and support for additional option --summary to the
> > suppress the output to minimal in case there are no warnings or
> > errors.

>
> In the past, Tanya has always supplied this to us as Java source. I
> would like to continue doing that. Is that okay?
>
> What is the new version number of this program? Can you be a bit more
> specific about the fixes? I don't know how to decide if this goes into
> our ITB testing, or needs to be pushed our more quickly.
>

> > I do not know who came up with the verify-gip-for-cemon-wrapper
> > script. I do not find it in ReSS CVS so at the moment assuming that
> > VDT put it in place. Script distributed in VDT doesn't give any
> > means to pass command line option to the Java class
> > TestOSGGlueSchema. I have attached the patched version of the
> > script that fixes this issue.

>
> I forget who came up with it, but it's checked into the VDT source code
> repository. We can update it at hte same time.
>
> -alain
>
>
>

--
Thanks & Regards

=============================================================

Parag Mhashilkar
Fermi National Accelerator Laboratory, MS 120
Wilson & Kirk Road, Batavia, IL - 60510.

Location: Wilson Hall, WH863
Phone: +1 (630) 840-6530
Fax: +1 (630) 840-2783
Email: parag@fnal.gov

=============================================================

Download TestOSGGlueSchema.java
text/x-java 19.3k

Download verify-gip-for-cemon-wrapper
application/x-shellscript 402b

#	Mon Feb 16 15:24:39 2009	kronenfe - Correspondence added		[Reply]
	Download (untitled) / with headers text/plain 369b On Mon Feb 16 15:11:48 2009, parag@fnal.gov wrote: > Scott, > > Looks like I gave you wrong java file in my last email :(. > > I have attached the correct one to the email now. Since I released the other one, is it ok if I upgrade the version to 1.6? I can't find anything in the java code referencing the version number, but I just wanted to double check with you.

#

Mon Feb 16 15:40:47 2009

parag@fnal.gov - Correspondence added

[Reply]

Subject:	Re: [vdt-support #4848] Patches to verify-gip-for-cemon
Date:	Mon, 16 Feb 2009 15:41:53 -0600
To:	vdt-support@OPENSCIENCEGRID.ORG
From:	Parag Mhashilkar <parag@fnal.gov>

Download (untitled) / with headers
text/plain 1.1k

Hi Scott,

Don't ask me why but the package follows the version from CVS tag
System.out.println("$Id: TestOSGGlueSchema.java,v 1.5 2009/02/11
22:26:54 parag Exp $");

Can you change it to v1.5.1 rather than 1.6 this time? This way, it will
not be too off from what cvs tag says.

I want to get rid of the this package and replace it with a better test
suite in coming future.

On Mon, 2009-02-16 at 15:24 -0600, Scot Kronenfeld via RT wrote:

> On Mon Feb 16 15:11:48 2009, parag@fnal.gov wrote:

> > Scott,
> >
> > Looks like I gave you wrong java file in my last email :(.
> >
> > I have attached the correct one to the email now.

>
> Since I released the other one, is it ok if I upgrade the version to
> 1.6? I can't find anything in the java code referencing the version
> number, but I just wanted to double check with you.
>

--
Thanks & Regards

=============================================================

Parag Mhashilkar
Fermi National Accelerator Laboratory, MS 120
Wilson & Kirk Road, Batavia, IL - 60510.

Location: Wilson Hall, WH863
Phone: +1 (630) 840-6530
Fax: +1 (630) 840-2783
Email: parag@fnal.gov

=============================================================

#

Mon Feb 16 15:56:47 2009

kronenfe - Correspondence added

[Reply]

Subject:	Re: [vdt-support #4848] Patches to verify-gip-for-cemon
Date:	Mon, 16 Feb 2009 15:56:40 -0600
To:	vdt-support@OPENSCIENCEGRID.ORG
From:	Scot Kronenfeld <kronenfe@cs.wisc.edu>

Download (untitled) / with headers
text/plain 219b

> Can you change it to v1.5.1 rather than 1.6 this time? This way, it will
> not be too off from what cvs tag says.

Ok, will do. Thanks for letting me know about that.

I'll have it released shortly in the ITB cache.

#

Mon Feb 16 15:57:41 2009

kronenfe - Comments added

[Reply]

Subject:	[vdt-support #4848] SVN commit, rev 8724
To:	vdt-support@cs.wisc.edu
From:	kronenfe@cs.wisc.edu

Download (untitled) / with headers
text/plain 300b

Commit comment:
Upgraded Verify-GIP-For-CEMon from 1.5 to 1.5.1

Changed files:
U vdt/branches/vdt-1.10.1-gums-prima/Verify-GIP-For-CEMon/verify-gip-for-cemon/verify-gip-for-cemon-wrapper
U vdt/branches/vdt-1.10.1-gums-prima/defs

To generate a diff:
svn diff -c 8724 file:///p/vdt/workspace/svn

#	Mon Feb 16 15:59:23 2009	kronenfe - Stolen from roy

#	Mon Feb 16 15:59:39 2009	kronenfe - AdminCc kronenfe deleted

#	Mon Feb 16 15:59:55 2009	kronenfe - Priority changed from (no value) to '-3'

#	Mon Feb 16 15:59:55 2009	kronenfe - Fix scheduled CUR added

#	Tue Apr 21 15:58:41 2009	kronenfe - Status changed from 'open' to 'resolved'

#	Tue Apr 21 15:58:50 2009	kronenfe - Fixed in 1.10.1v added